refactor: Hide implementation details of StrConsts

.editorconfig

@@ -4,7 +4,7 @@ root = true
 [*]
 charset = utf-8
 indent_style = space
-indent_size = 4
+indent_size = 2
 insert_final_newline = true
 trim_trailing_whitespace = true
 max_line_length = 120

.gitignore

@@ -6,3 +6,4 @@
 *.compiled
 *.bak
 *.lps
+backup/

Chameleon.lpi

@@ -1,16 +1,16 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <CONFIG>
   <ProjectOptions>
-    <Version Value="11" />
+    <Version Value="12"/>
     <PathDelim Value="\"/>
     <General>
       <Flags>
         <MainUnitHasUsesSectionForAllUnits Value="False"/>
         <MainUnitHasCreateFormStatements Value="False"/>
         <MainUnitHasTitleStatement Value="False"/>
+        <CompatibilityMode Value="True"/>
       </Flags>
       <SessionStorage Value="InProjectDir"/>
-      <MainUnit Value="0" />
       <Title Value="Chameleon"/>
       <UseAppBundle Value="False"/>
       <ResourceType Value="res"/>
@@ -25,10 +25,8 @@
     <VersionInfo>
       <UseVersionInfo Value="True"/>
       <AutoIncrementBuild Value="True"/>
-      <RevisionNr Value="0" />
-      <BuildNr Value="2" />
-      <MajorVersionNr Value="0" />
       <MinorVersionNr Value="1"/>
+      <BuildNr Value="2"/>
     </VersionInfo>
     <BuildModes Count="1">
       <Item1 Name="Default" Default="True"/>
@@ -99,6 +97,9 @@
       </SyntaxOptions>
     </Parsing>
     <Linking>
+      <Debugging>
+        <DebugInfoType Value="dsDwarf2Set"/>
+      </Debugging>
       <Options>
         <Win32>
           <GraphicApplication Value="True"/>

StrConsts.pas

@@ -4,6 +4,13 @@ unit StrConsts;
 
 interface
 
+uses Classes;
+
+function GetWindowStyleNames(style: Integer): TStringList;
+function GetExtendedWindowStyleNames(style: Integer): TStringList;
+
+implementation
+
 uses Windows;
 
 const
@@ -101,6 +108,28 @@ const
     'Transparent',
     'Raised edge');
 
-implementation
+function GetWindowStyleNames(style: Integer): TStringList;
+var
+  list: TStringList;
+  i: Integer;
+begin
+  list := TStringList.Create();
+  for i := Low(WindowStyle) to High(WindowStyle) do
+    if ((style and WindowStyle[i]) = WindowStyle[i]) then
+      list.Add(WindowStyleName[i]);
+  Result := list;
+end;
+
+function GetExtendedWindowStyleNames(style: Integer): TStringList;
+var
+  list: TStringList;
+  i: Integer;
+begin
+  list := TStringList.Create();
+  for i := Low(ExtendedWindowStyle) to High(ExtendedWindowStyle) do
+    if ((style and ExtendedWindowStyle[i]) = ExtendedWindowStyle[i]) then
+      list.Add(ExtendedWindowStyleName[i]);
+  Result := list;
+end;
 
 end.

frmMain.lfm

@@ -11,14 +11,13 @@ object MainForm: TMainForm
   Font.Color = clWindowText
   Font.Height = -14
   Font.Name = 'Tahoma'
-  LCLVersion = '2.0.6.0'
+  LCLVersion = '2.2.0.4'
   object lblDelayTime: TLabel
     Left = 21
     Height = 17
     Top = 11
     Width = 168
     Caption = 'Time until restoring control:'
-    ParentColor = False
   end
   object Label1: TLabel
     Left = 273
@@ -26,14 +25,12 @@ object MainForm: TMainForm
     Top = 11
     Width = 32
     Caption = 'msec'
-    ParentColor = False
   end
   object DelayTime: TSpinEdit
     Left = 206
     Height = 25
     Top = 11
     Width = 63
-    MaxValue = 0
     TabOrder = 0
     Value = 3000
   end
@@ -60,7 +57,6 @@ object MainForm: TMainForm
         Width = 78
         Caption = 'HWND value'
         Enabled = False
-        ParentColor = False
       end
       object Information: TButton
         Left = 21
@@ -114,7 +110,6 @@ object MainForm: TMainForm
         Top = 11
         Width = 81
         Caption = 'Unit file name'
-        ParentColor = False
       end
       object Label4: TLabel
         Left = 21
@@ -122,7 +117,6 @@ object MainForm: TMainForm
         Top = 80
         Width = 70
         Caption = 'Form name'
-        ParentColor = False
       end
       object PasFileName: TEdit
         Left = 21
@@ -174,7 +168,6 @@ object MainForm: TMainForm
         Top = 11
         Width = 75
         Caption = 'RC file name'
-        ParentColor = False
       end
       object RCFileName: TEdit
         Left = 21
@@ -232,7 +225,7 @@ object MainForm: TMainForm
   end
   object SaveDialog1: TSaveDialog
     Options = [ofOverwritePrompt, ofHideReadOnly]
-    left = 366
+    Left = 366
-    top = 240
+    Top = 240
   end
 end

frmMain.pas

@@ -52,6 +52,8 @@ type
       PasList: TStrings);
     procedure GeneratePasFile(const filename, frmname: string; PasList: TStrings);
     procedure GetWinInfo(wnd: HWND; ParentNode: TTreeNode);
+    procedure GetWinInfoStyle(wnd: HWND; ParentNode: TTreeNode);
+    procedure GetWinInfoExtendedStyle(wnd: HWND; ParentNode: TTreeNode);
     procedure EnableSavePas;
     procedure EnableWndInput;
   public
@@ -76,7 +78,6 @@ var
   node1, node2: TTreeNode;
   childlist: TList;
   EnumParams: TEnumParams;
-  style, exstyle: integer;
   parentWnd: HWND;
   itemtext: array [0..300] of char;
 begin
@@ -92,8 +93,6 @@ begin
   GetWindowRect(wnd, R1);
   Windows.GetClientRect(wnd, R2);
   GetClassName(wnd, class_name, 100);
-  style := GetWindowLong(wnd, GWL_STYLE);
-  exstyle := GetWindowLong(wnd, GWL_EXSTYLE);
   parentWnd := GetParent(wnd);
   EnumParams.List := childlist;
   EnumParams.ParentWnd := wnd;
@@ -105,17 +104,8 @@ begin
     AddChild(ParentNode, 'Caption = ' + Text);
     AddChild(ParentNode, 'Class name = ' + class_name);
     AddChild(ParentNode, 'Parent Handle = ' + IntToStr(parentWnd));
-    node1 := AddChild(ParentNode, 'Style');
+    GetWinInfoStyle(wnd, ParentNode);
-    AddChild(node1, 'Value = ' + IntToStr(style));
+    GetWinInfoExtendedStyle(wnd, ParentNode);
-    for i := Low(WindowStyle) to High(WindowStyle) do
-      if ((style and WindowStyle[i]) = WindowStyle[i]) then
-        AddChild(node1, WindowStyleName[i]);
-
-    node1 := AddChild(ParentNode, 'Extended Style');
-    AddChild(node1, 'Value = ' + IntToStr(exstyle));
-    for i := Low(WindowStyle) to High(WindowStyle) do
-      if ((style and ExtendedWindowStyle[i]) = ExtendedWindowStyle[i]) then
-        AddChild(node1, ExtendedWindowStyleName[i]);
     node1 := AddChild(ParentNode, 'Placement');
     AddChild(node1, 'Left = ' + IntToStr(R1.Left));
     AddChild(node1, 'Top = ' + IntToStr(R1.Top));
@@ -150,6 +140,50 @@ begin
   childlist.Free;
 end;
 
+procedure TMainForm.GetWinInfoStyle(wnd: HWND; ParentNode: TTreeNode);
+var
+  style: Integer;
+  list: TStringList;
+  node1: TTreeNode;
+  i: Integer;
+begin
+  style := GetWindowLong(wnd, GWL_STYLE);
+  list := GetWindowStyleNames(style);
+
+  with Results.TreeView1.Items do
+  begin
+    node1 := AddChild(ParentNode, 'Style');
+    AddChild(node1, 'Value = ' + IntToStr(style));
+
+    for i := 0 to list.Count - 1 do
+      AddChild(node1, list[i]);
+  end;
+
+  list.Free();
+end;
+
+procedure TMainForm.GetWinInfoExtendedStyle(wnd: HWND; ParentNode: TTreeNode);
+var
+  style: Integer;
+  list: TStringList;
+  node1: TTreeNode;
+  i: Integer;
+begin
+  style := GetWindowLong(wnd, GWL_EXSTYLE);
+  list := GetExtendedWindowStyleNames(style);
+
+  with Results.TreeView1.Items do
+  begin
+    node1 := AddChild(ParentNode, 'Extended Style');
+    AddChild(node1, 'Value = ' + IntToStr(style));
+
+    for i := 0 to list.Count - 1 do
+      AddChild(node1, list[i]);
+  end;
+
+  list.Free();
+end;
+
 procedure TMainForm.InformationClick(Sender: TObject);
 var
   wnd: HWND;